Define HAVE_SSL_GET_SHUTDOWN when available (Windows)

[Zenju]

Hi,

Just noticed, that the following code fragment in lib/vtls/openssl.c is disabled in the Windows build because HAVE_SSL_GET_SHUTDOWN is undefined, but shouldn't be:

#ifdef HAVE_SSL_GET_SHUTDOWN
            switch (SSL_get_shutdown(BACKEND->handle))
            {
                case SSL_SENT_SHUTDOWN:
                    infof(data, "SSL_get_shutdown() returned SSL_SENT_SHUTDOWN\n");
                    break;
                case SSL_RECEIVED_SHUTDOWN:
                    infof(data, "SSL_get_shutdown() returned SSL_RECEIVED_SHUTDOWN\n");
                    break;
                case SSL_SENT_SHUTDOWN|SSL_RECEIVED_SHUTDOWN:
                    infof(data, "SSL_get_shutdown() returned SSL_SENT_SHUTDOWN|"
                          "SSL_RECEIVED__SHUTDOWN\n");
                    break;
            }
#endif

I'm not sure in which OpenSSL version SSL_get_shutdown() was first introduced, but according to the docs it is at least available beginning with 1.0.2.

The patch follows the implementation strategy of other HAVE_* defines found in openssl.c, like HAVE_X509_GET0_SIGNATURE. If this is not the right approach, feel free to change.

Best, Zenju

[bagder]

So then maybe also remove the check for it from configure.ac? It seems wrong to have two different checks for it...

[Zenju]

I assume the HAVE_SSL_GET_SHUTDOWN mentioned in packages\vms\config_h.com should be scraped as well?

[jay]

@wb8tyw can you tell us how does this PR affect VMS builds? Can we remove this for example?

[bagder]

With the define handled in vtls/openssl.c, no platform should need to handle it special...

[bagder]

Thanks!