Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Convert errant elseif() to else() #4101

Closed

Conversation

@KyleFromKitware
Copy link
Contributor

KyleFromKitware commented Jul 9, 2019

CMake interprets an elseif() with no arguments as elseif(FALSE),
resulting in the elseif() block not being executed. That is not what
was intended here. Change the empty elseif() to an else() as it was
intended.

This was reported to CMake in merge request !3515.

Reported-by: Artalus artalus-mail@yandex.ru

CMake interprets an elseif() with no arguments as elseif(FALSE),
resulting in the elseif() block not being executed. That is not what
was intended here. Change the empty elseif() to an else() as it was
intended.

Reported-by: Artalus <artalus-mail@yandex.ru>
Copy link
Member

danielgustafsson left a comment

LGTM, will push once the Appveyor and Travis builds have done a few passes on this one.

@danielgustafsson

This comment has been minimized.

Copy link
Member

danielgustafsson commented Jul 9, 2019

Pushed to master, thanks!

caraitto added a commit to caraitto/curl that referenced this pull request Jul 23, 2019
CMake interprets an elseif() with no arguments as elseif(FALSE),
resulting in the elseif() block not being executed. That is not what
was intended here. Change the empty elseif() to an else() as it was
intended.

Closes curl#4101
Reported-by: Artalus <artalus-mail@yandex.ru>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.