nss: inspect returnvalue of token check #4110
Conversation
PK11_IsPresent() checks for the token for the given slot is available, and sets needlogin flags for the PK11_Authenticate() call. Should it return false, we should however treat it as an error and bail out.
The only purpose of the However, your patch looks fine and it could ease debugging of some unexpected situations. |
Thanks |
Aha, when scanning the NSS code (not carefully enough) I came across cases where the return value was checked and missed these. This makes a lot of sense though, thanks for clarifying. |
PK11_IsPresent() checks for the token for the given slot is available, and sets needlogin flags for the PK11_Authenticate() call. Should it return false, we should however treat it as an error and bail out. Closes curl#4110
PK11_IsPresent() checks for the token for the given slot is available, and sets needlogin flags for the PK11_Authenticate() call. Should it return false, we should however treat it as an error and bail out.
@kdudka is there a reason to ignore the returnvalue of PK11_IsPresent() that I'm not seeing?