Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
libcurl: use chunked Transfer-Encoding for HTTP_POST if size unknown #4138
If using the read callback for HTTP_POST, and POSTFIELDSIZE is not set, automatically add a Transfer-Encoding: chunked header, same as it is already done for HTTP_PUT, HTTP_POST_FORM and HTTP_POST_MIME. Update test 1514 according to the new behaviour.
mkauf added a commit to mkauf/mod_md that referenced this pull request
Oct 25, 2019
libcurl 7.66.0 automatically adds a "Transfer-Encoding: chunked" header if the content length is not known to libcurl, because of this change: curl/curl#4138 libcurl does not parse custom "Content-Length" headers, it needs the content length using the options CURLOPT_POSTFIELDSIZE(_LARGE) and CURLOPT_INFILESIZE(_LARGE). The "Boulder" server rejects requests with both headers, but the host acme-v02.api.letsencrypt.org accepts such requests, probably because there's a reverse proxy.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.