Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uplibcurl: use chunked Transfer-Encoding for HTTP_POST if size unknown #4138
+19
−3
Conversation
Kova93
force-pushed the
Kova93:master
branch
from
0ff3e89
to
59c62e3
Jul 23, 2019
Kova93
force-pushed the
Kova93:master
branch
from
59c62e3
to
8672595
Jul 24, 2019
bagder
approved these changes
Jul 25, 2019
|
I think it makes sense to unify the behavior like this. Is there any docs that need updating after this fix? |
This comment has been minimized.
This comment has been minimized.
|
Yes, the doc of CURLOPT_POST has to be updated. |
This comment has been minimized.
This comment has been minimized.
|
will you make that change as well as part of this PR? |
This comment has been minimized.
This comment has been minimized.
|
Thanks! I updated the docs slightly before I pushed. |
bagder
closed this
in
802aa5a
Jul 29, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks, and sorry for not responding, I was away for the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Kova93 commentedJul 22, 2019
If using the read callback for HTTP_POST, and POSTFIELDSIZE is not set,
automatically add a Transfer-Encoding: chunked header, same as it is
already done for HTTP_PUT, HTTP_POST_FORM and HTTP_POST_MIME.
Update test 1514 according to the new behaviour.