Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: fix typo in comment #4167

Closed
wants to merge 1 commit into from

Conversation

@jcen
Copy link
Contributor

jcen commented Jul 30, 2019

No description provided.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jul 30, 2019

Thanks, but this made the line too long and... I think we can do better than just fixing the name since "Please see the curl_easy_setopt(3) man page for callbacks returning this structure" is also incorrect. It is primarily documented in the CURLOPT_CHUNK_BGN_FUNCTION.3 man page.

I propose we replace the entire comment block there with something like:

/* Information about a single file, used when doing FTP wildcard matching */
@bagder bagder self-requested a review Jul 30, 2019
@bagder bagder dismissed their stale review Jul 30, 2019

second thoughts

@bagder bagder closed this in d414f6b Jul 30, 2019
@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jul 30, 2019

Thanks! I amended your commit and pushed it.

BTW, you used just "Justin" as your real name as the commit author. If you would like to instead show your full name, let me know what it is and I'll fix it.

@bagder bagder removed their request for review Jul 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.