Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quiche: first working HTTP/3 request #4193

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

commented Aug 5, 2019

  • enable debug log
  • fix use of quiche API
  • use download buffer
  • separate header/body
quiche: first working HTTP/3 request
 - enable debug log
 - fix use of quiche API
 - use download buffer
 - separate header/body

@bagder bagder added the HTTP/3 label Aug 5, 2019

@ghedo

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Just a small note, but when I build with HTTP/2 disabled (didn't have nghttp2 installed) I get:

vquic/quiche.c: In function ‘http_request’:
vquic/quiche.c:601:13: error: ‘struct HTTP’ has no member named ‘upload_left’
       stream->upload_left = conn->data->state.infilesize;
             ^~
vquic/quiche.c:604:13: error: ‘struct HTTP’ has no member named ‘upload_left’
       stream->upload_left = -1; /* unknown, but not zero */
             ^~
make[2]: *** [Makefile:3574: vquic/libcurlu_la-quiche.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/ghedo/devel/third-party/curl/lib'
make[1]: *** [Makefile:1047: all] Error 2
make[1]: Leaving directory '/home/ghedo/devel/third-party/curl/lib'
make: *** [Makefile:943: all-recursive] Error 1

Enabling HTTP/2 fixes the build.

@bagder

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Oops, thanks. I'll give that a fixup!

@bagder bagder closed this in dc35631 Aug 6, 2019

@bagder bagder deleted the bagder/quiche-success branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.