Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: remove torture tests from coverage to make it complete in time #4223

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Aug 13, 2019

No description provided.

@bagder
Copy link
Member Author

@bagder bagder commented Aug 14, 2019

coveralls seems broken <title>Coveralls :: Oops, something went wrong (500)</title>

@jay
Copy link
Member

@jay jay commented Aug 14, 2019

Ignore it, I'm seeing something similar it might be cloudfront related, that is the only host holding things up.

d3dy5gmtp8yhk7.cloudfront.net

== TIMING INFO ============
ClientConnected: 02:54:49.291
ClientBeginRequest: 02:54:49.320
GotRequestHeaders: 02:54:49.320
ClientDoneRequest: 02:54:49.320
Determine Gateway: 0ms
DNS Lookup: 70ms
TCP/IP Connect: 20999ms
HTTPS Handshake: 0ms
ServerConnected: 02:55:10.392
FiddlerBeginRequest: 00:00:00.000
ServerGotRequest: 00:00:00.000
ServerBeginResponse: 00:00:00.000
GotResponseHeaders: 00:00:00.000
ServerDoneResponse: 00:00:00.000
ClientBeginResponse: 02:55:10.392
ClientDoneResponse: 02:55:10.392

Overall Elapsed: 0:00:21.072

@bagder
Copy link
Member Author

@bagder bagder commented Aug 14, 2019

Thanks!

The removed torture tests took the coverage down from ~75% to ~70%. Clearly lots of exit paths that the normal tests never hit. But now the coverage build completed in 32 minutes instead of timing out after 50 so I see no real choice for us here. An alternative would be to run a few torture tests just to exercise the most common exit paths... I'll add a few and see how this affects the build.

To see if the coverage bumps a little and yet still manage to complete in time
@bagder
Copy link
Member Author

@bagder bagder commented Aug 15, 2019

With just a small set of torture tests, we're back on 74.589%

@bagder bagder closed this in 0b1e74b Aug 15, 2019
@bagder bagder deleted the bagder/reduced-coverage branch Aug 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.