Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/examples/curlx] Initialise 'mimetype' #4248

Closed
wants to merge 2 commits into from
Closed

[docs/examples/curlx] Initialise 'mimetype' #4248

wants to merge 2 commits into from

Conversation

@gvanem
Copy link
Contributor

gvanem commented Aug 20, 2019

With MSVC's option /RTCu (Uninitialized local usage checks), a simple curlx.exe fails with a dialogue box:
curlx-RTC

A simple fix is just to initialise to NULL.

With MSVC's option `/RTCu` (Uninitialized local usage checks), a simple `curlx.exe` fails with a dialogue box.
A simple fix is just to initialise to NULL.
@gvanem gvanem changed the title Initialise 'mimetype' [docs/examples/curlx] Initialise 'mimetype' Aug 20, 2019
With MSVC's `/RTCu` option and no `-p12 arg` on the cmd-line, the same fatal dialogue box is triggered when
```c
p12bio = BIO_new_file(p.p12file, "rb");
```
is called.
Copy link
Contributor Author

gvanem left a comment

What is needed now for a merge?

@bagder bagder closed this in 216dd88 Aug 21, 2019
@bagder
Copy link
Member

bagder commented Aug 21, 2019

You would:

  1. squash the commits as necessary
  2. make sure the commit message(s) follow(s) the template (often add a "closes #....")
  3. merge to master
  4. rebase to origin/master
  5. push on master

Done! (and I just did that for you)
Thanks!

@gvanem
Copy link
Contributor Author

gvanem commented Aug 21, 2019

Impossible AFAICS to this from the Github web UI...

@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.