Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl_fillreadbuffer: avoid double-free trailer buf on error #4307

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@bagder
Copy link
Member

@bagder bagder commented Sep 9, 2019

Curl_add_bufferf() frees that buffer itself on failure!

Reported-by: Thomas Vegas

lib/transfer.c Outdated Show resolved Hide resolved
Reviewed-by: Jay Satiro
Reported-by: Thomas Vegas

Closes #4307
@bagder bagder force-pushed the bagder/trailer-buf-free branch from d59a41a to c4c9e07 Sep 9, 2019
jay
jay approved these changes Sep 9, 2019
@bagder bagder closed this in c4c9e07 Sep 9, 2019
@bagder bagder merged commit c4c9e07 into master Sep 9, 2019
13 of 17 checks passed
@bagder bagder deleted the bagder/trailer-buf-free branch Sep 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants