Curl_fillreadbuffer: avoid double-free trailer buf on error#4307
Merged
Curl_fillreadbuffer: avoid double-free trailer buf on error#4307
Conversation
jay
reviewed
Sep 9, 2019
Reviewed-by: Jay Satiro Reported-by: Thomas Vegas Closes #4307
bagder
force-pushed
the
bagder/trailer-buf-free
branch
from
d59a41a to
c4c9e07
Compare
jay
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curl_add_bufferf() frees that buffer itself on failure!
Reported-by: Thomas Vegas