Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl_fillreadbuffer: avoid double-free trailer buf on error #4307

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@bagder
Copy link
Member

commented Sep 9, 2019

Curl_add_bufferf() frees that buffer itself on failure!

Reported-by: Thomas Vegas

lib/transfer.c Outdated Show resolved Hide resolved
Curl_fillreadbuffer: avoid double-free trailer buf on error
Reviewed-by: Jay Satiro
Reported-by: Thomas Vegas

Closes #4307

@bagder bagder force-pushed the bagder/trailer-buf-free branch from d59a41a to c4c9e07 Sep 9, 2019

@jay
jay approved these changes Sep 9, 2019

@bagder bagder closed this in c4c9e07 Sep 9, 2019

@bagder bagder merged commit c4c9e07 into master Sep 9, 2019

13 of 17 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
FreeBSD FreeBSD:freebsd-10-4-release-amd64 Task Summary
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
FreeBSD FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
FreeBSD FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Python No code changes detected
Details
buildbot/curl-unthreaded-solaris10-i386 Build done.
Details
buildbot/curl-unthreaded-solaris10-sparc Build done.
Details
buildbot/curl_winssl_cross_x64 Build done.
Details
buildbot/curl_winssl_cross_x64_dbg Build done.
Details
buildbot/curl_winssl_cross_x86 Build done.
Details
buildbot/curl_winssl_cross_x86_dbg Build done.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.07%) to 74.519%
Details

@bagder bagder deleted the bagder/trailer-buf-free branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.