Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: fix memory leaked by parse_metalink() #4326

Closed
wants to merge 2 commits into from
Closed

Conversation

@kdudka
Copy link
Collaborator

kdudka commented Sep 11, 2019

This commit fixes a regression introduced by curl-7_65_3-5-gb88940850.
Detected by tests 2005, 2008, 2009, 2010, 2011, and 2012 with valgrind
and libmetalink enabled.

This commit fixes a regression introduced by curl-7_65_3-5-gb88940850.
Detected by tests 2005, 2008, 2009, 2010, 2011, and 2012 with valgrind
and libmetalink enabled.
@bagder
Copy link
Member

bagder commented Sep 11, 2019

I propose you make the header file provide an empty macro for the function for the builds without metalink present!

Add empty macro for delete_metalinkfile() when USE_METALINK
is not defined.
@kdudka
Copy link
Collaborator Author

kdudka commented Sep 12, 2019

Added. Thanks for review!

@kdudka kdudka closed this in 1ca91bc Sep 13, 2019
@kdudka kdudka deleted the kdudka:meta-leak branch Sep 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.