Allow empty authority for unknown schemes#4349
Closed
jfinkhaeuser wants to merge 6 commits intocurl:masterfrom
jfinkhaeuser:allow-empty-authority-for-unknown-scheme
Closed
Allow empty authority for unknown schemes#4349jfinkhaeuser wants to merge 6 commits intocurl:masterfrom jfinkhaeuser:allow-empty-authority-for-unknown-scheme
jfinkhaeuser wants to merge 6 commits intocurl:masterfrom
jfinkhaeuser:allow-empty-authority-for-unknown-scheme
Conversation
for use with unknown schemes (i.e. not "file:///") to override cURL's demand that an authority exists.
parts should fail. With it, it should work. The flag effectively disables the hostname check if it's set, and the hostname is empty.
Contributor
Author
|
I've got to run - if there are tests failing, or there should be changes, I'll look at them in a few days, probably. Locally everything looked fine. And obviously if you'd like changes, I'm happy to provide them. |
Member
|
I think this is a sensible way to make the parser handle such URLs so I'm in favor of merging once things are green. Still missing: documentation of the new flag and |
Contributor
Author
|
Makes sense - will probably get to those changes tomorrow. |
Member
|
The two builds using boringssl fail due to other reasons, not your fault! |
Contributor
Author
|
Excellent, then let me know if you want any other changes, otherwise I'm done. |
Member
|
Thanks! |
Contributor
Author
|
No worries, glad to be of help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discussed this briefly with @bagder
According to RFC3986 Section 3.2.2 on page 21
cURL implements this behaviour for the
filescheme, but doesn't - and cannot - implement this behaviour for schemes it does not know. For such schemes, passing a new flag that permits empty authority sections is desirable.This PR adds such a
CURLU_NO_AUTHORITYflag, as well as test cases.