Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doh: clean up dangling DOH handles on easy close #4366

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@bagder
Copy link
Member

commented Sep 16, 2019

If you set the same URL for target as for DoH (and it isn't a DoH
server), like "https://example.com" in both, the easy handles used for
the DoH requests could be left "dangling" and end up not getting freed.

Reported-by: Paul Dreik @pauldreik

@bagder bagder changed the title doh: clean up handling DOH handles on easy close doh: clean up dangling DOH handles on easy close Sep 16, 2019
If you set the same URL for target as for DoH (and it isn't a DoH
server), like "https://example.com" in both, the easy handles used for
the DoH requests could be left "dangling" and end up not getting freed.

Reported-by: Paul Dreik
Closes #4366
@bagder bagder force-pushed the bagder/doh-memleak branch from 244e84a to 9bc44ff Sep 16, 2019
@bagder bagder closed this in 9bc44ff Sep 16, 2019
@bagder bagder merged commit 9bc44ff into master Sep 16, 2019
13 of 15 checks passed
13 of 15 checks passed
Build
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
FreeBSD FreeBSD:freebsd-10-4-release-amd64 Task Summary
Details
FreeBSD FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
FreeBSD FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Python No code changes detected
Details
buildbot/curl-unthreaded-solaris10-i386 Build done.
Details
buildbot/curl-unthreaded-solaris10-sparc Build done.
Details
buildbot/curl_winssl_cross_x64 Build done.
Details
buildbot/curl_winssl_cross_x64_dbg Build done.
Details
buildbot/curl_winssl_cross_x86 Build done.
Details
buildbot/curl_winssl_cross_x86_dbg Build done.
Details
@bagder bagder deleted the bagder/doh-memleak branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.