Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doh: clean up dangling DOH handles on easy close #4366

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 16, 2019

If you set the same URL for target as for DoH (and it isn't a DoH
server), like "https://example.com" in both, the easy handles used for
the DoH requests could be left "dangling" and end up not getting freed.

Reported-by: Paul Dreik @pauldreik

@bagder bagder added memory-leak name lookup DNS and related tech labels Sep 16, 2019
@bagder bagder changed the title doh: clean up handling DOH handles on easy close doh: clean up dangling DOH handles on easy close Sep 16, 2019
If you set the same URL for target as for DoH (and it isn't a DoH
server), like "https://example.com" in both, the easy handles used for
the DoH requests could be left "dangling" and end up not getting freed.

Reported-by: Paul Dreik
Closes #4366
@bagder bagder closed this in 9bc44ff Sep 16, 2019
@bagder bagder merged commit 9bc44ff into master Sep 16, 2019
@bagder bagder deleted the bagder/doh-memleak branch September 19, 2019 13:13
@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
memory-leak name lookup DNS and related tech
Development

Successfully merging this pull request may close these issues.

1 participant