appveyor: upgrade VS2017 to VS2019 - #4383
Closed
bagder wants to merge 3 commits into
Closed
Conversation
MarcelRaad
reviewed
Sep 19, 2019
MarcelRaad
approved these changes
Sep 19, 2019
Member
Author
|
Ugha, that failed so spectacularly I'm afraid I don't know where to go next... |
Member
|
It looks like there's an extra space my guess "-A x64" is quoted and it should be -A x64 but you could probably do -Ax64 if you need to quote TARGET |
Member
Author
|
hm, yes. So where does that originate from? The documentation says |
Member
Author
|
Hm, I bet the quotes make it so... |
Member
|
I updated my comment after I made it, my guess you are quoting so it sees it as one argument |
Member
Author
|
I'm testing this out in the #4387 PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.