Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: upgrade VS2017 to VS2019 #4383

Closed
wants to merge 3 commits into from

Conversation

@bagder
Copy link
Member

commented Sep 19, 2019

No description provided.

appveyor.yml Outdated Show resolved Hide resolved
@bagder

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

Ugha, that failed so spectacularly I'm afraid I don't know where to go next...

@jay

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

It looks like there's an extra space
Configuration='Debug' Platform=' x64'.

my guess "-A x64" is quoted and it should be -A x64 but you could probably do -Ax64 if you need to quote TARGET

@bagder

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

hm, yes. So where does that originate from? The documentation says -A x64 so surely that's not the space?

@bagder

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

Hm, I bet the quotes make it so...

@jay

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

I updated my comment after I made it, my guess you are quoting so it sees it as one argument
"-A x64"
then I guess cmake parses it as -A " x64"

bagder added a commit that referenced this pull request Sep 20, 2019
Closes #4383
@bagder bagder referenced this pull request Sep 20, 2019
@bagder

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2019

I'm testing this out in the #4387 PR

@bagder bagder closed this in 0b7d7ab Sep 21, 2019
@bagder bagder deleted the bagder/appveyor-vs2019 branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.