Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appveyor: upgrade VS2017 to VS2019 #4383

Closed
wants to merge 3 commits into from
Closed

appveyor: upgrade VS2017 to VS2019 #4383

wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 19, 2019

No description provided.

MarcelRaad
MarcelRaad reviewed Sep 19, 2019
View reviewed changes
appveyor.yml Outdated Show resolved Hide resolved
@bagder
Copy link
Member Author

bagder commented Sep 19, 2019

Ugha, that failed so spectacularly I'm afraid I don't know where to go next...

@jay
Copy link
Member

jay commented Sep 19, 2019 •
edited
Loading

It looks like there's an extra space
Configuration='Debug' Platform=' x64'.

my guess "-A x64" is quoted and it should be -A x64 but you could probably do -Ax64 if you need to quote TARGET

@bagder
Copy link
Member Author

bagder commented Sep 19, 2019 •
edited
Loading

hm, yes. So where does that originate from? The documentation says -A x64 so surely that's not the space?

@bagder
Copy link
Member Author

bagder commented Sep 19, 2019

Hm, I bet the quotes make it so...

@jay
Copy link
Member

jay commented Sep 19, 2019

I updated my comment after I made it, my guess you are quoting so it sees it as one argument
"-A x64"
then I guess cmake parses it as -A " x64"

@bagder bagder mentioned this pull request Sep 19, 2019
Closed
bagder added a commit that referenced this pull request Sep 20, 2019
@bagder
appveyor: upgrade VS2017 to VS2019
befbe12 
Closes #4383
@bagder bagder mentioned this pull request Sep 20, 2019
Closed
@bagder
Copy link
Member Author

bagder commented Sep 21, 2019

I'm testing this out in the #4387 PR

@bagder bagder closed this in 0b7d7ab Sep 21, 2019
@bagder bagder deleted the bagder/appveyor-vs2019 branch September 26, 2019 11:53
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bagder @jay @MarcelRaad