Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: fix narrowing conversion warnings #4398

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

commented Sep 22, 2019

Curl_timeleft returns timediff_t, which is 64 bits wide also on
32-bit systems since commit b1616da.

@bagder
bagder approved these changes Sep 22, 2019
Copy link
Member

left a comment

Thanks. Where did you get these warnings and can we get such a build going in the CI somewhere?

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2019

I got them with 32-bit MinGW. They used to be visible in one of my autobuilds, but unfortunately they're currently down because of problems with the mail server.

I'll look into adding such a build to AppVeyor!

Curl_timeleft returns `timediff_t`, which is 64 bits wide also on
32-bit systems since commit b1616da.

Closes #4398
@MarcelRaad MarcelRaad force-pushed the MarcelRaad:vtls_timeleft_warnings branch from bcd2348 to 52641ab Sep 22, 2019
@MarcelRaad MarcelRaad deleted the MarcelRaad:vtls_timeleft_warnings branch Sep 23, 2019
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 24, 2019
With OpenSSL, WinSSL, and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 24, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 24, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 27, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 27, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 30, 2019
With WinSSL and testing enabled so that it would have detected most of
the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes curl#4433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.