vtls: fix narrowing conversion warnings#4398
Closed
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
bagder
approved these changes
Sep 22, 2019
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Thanks. Where did you get these warnings and can we get such a build going in the CI somewhere?
Member
Author
|
I got them with 32-bit MinGW. They used to be visible in one of my autobuilds, but unfortunately they're currently down because of problems with the mail server. I'll look into adding such a build to AppVeyor! |
MarcelRaad
force-pushed
the
vtls_timeleft_warnings
branch
from
bcd2348 to
52641ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curl_timeleft returns
timediff_t, which is 64 bits wide also on32-bit systems since commit b1616da.