Skip to content

doh: respect timeout and restrict debug builds to http and https - #4406

Closed
pauldreik wants to merge 2 commits into
curl:masterfrom
pauldreik:paul/check_doh_timeout
Closed

pauldreik wants to merge 2 commits into
curl:masterfrom
pauldreik:paul/check_doh_timeout

Conversation

@pauldreik

Copy link
Copy Markdown
Contributor

doh did not time out properly. This change makes it return early with CURLE_OPERATION_TIMEDOUT.

In debug builds, doh could be configured to use any protocol, which lead to it trying to do doh over pop3 when the http fuzzer was running. It is now restricted to http and https.

Otherwise curl may be told to use for instance pop3 to
communicate with the doh server, which most likely
is not what you want.

Found through fuzzing.
@bagder bagder closed this in bb74201 Sep 23, 2019
bagder pushed a commit that referenced this pull request Sep 23, 2019
Otherwise curl may be told to use for instance pop3 to
communicate with the doh server, which most likely
is not what you want.

Found through fuzzing.

Closes #4406
@bagder

bagder commented Sep 23, 2019

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants