Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mkdir on OSX/Darwin requires -p argument before dir #4407

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/HTTP3.md
Expand Up @@ -27,6 +27,9 @@ notice. It needs to be enabled at build-time.
Further development and tweaking of the HTTP/3 support in curl will happen in
in the master branch using pull-requests, just like ordinary changes.

To build on MacOS with provided recipes you may want to set `alias nproc="sysctl -n hw.ncpu"`
before running make commands.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we drop the -j use all together instead to make the command lines work better on more places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should add a note that parallel builds are supported with a -j <numcpu> keyword, so maintainers will use that in their build recipes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. Just checked sysctl -n hw.ncpu also working on the FreeBSD, so it seems that with ncpu for the Linux and alias for the *BSD/Darwin we are covering most of the systems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to promote "make tips" here and maintainers should really already know about make -j ...


# ngtcp2 version

## Build
Expand Down