Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: Fix comment typo about macosx-version-min compiler flag #4425

Closed
wants to merge 1 commit into from

Conversation

@jzinn
Copy link
Contributor

commented Sep 26, 2019

No description provided.

@jay jay requested a review from nickzman Sep 26, 2019
@jay

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Are you sure it's a typo, isn't mmacos-version-min valid?

@jay jay added the build label Sep 26, 2019
@jzinn

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

@jzinn

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

I had not considered that macos-version-min could be valid, given that macosx-version-min already exists. It looks like both are valid for clang but only one for gcc.

Here's a test showing that gcc accepts macosx-version-min:

$ touch empty.c
$ /opt/gcc-7.3.0/bin/gcc -O2 -fpic -shared empty.c -mmacosx-version-min=10.11

Here's a test showing that gcc does not accept macos-version-min:

$ touch empty.c
$ /opt/gcc-7.3.0/bin/gcc -O2 -fpic -shared empty.c -mmacos-version-min=10.11
gcc: error: unrecognized command line option ‘-mmacos-version-min=10.11’; did you mean ‘-mmacosx-version-min=’?

I also grepped through the current gcc source code and did not find macos-version-min.

Please close this if you like the current spelling.

Copy link
Collaborator

left a comment

The manual for cc in Xcode 11.1 says "-mmacosx-version-min", so that's good enough for me.

@jay jay closed this in c7e6b71 Sep 27, 2019
@jay

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.