quiche: update HTTP/3 config creation to new API #4437
Closed
Conversation
lib/vquic/quiche.c
Outdated
| if(!qs->h3config) | ||
| return CURLE_OUT_OF_MEMORY; | ||
|
|
||
| quiche_h3_config_set_max_header_list_size(qs->h3config, 1024); |
ghedo
Sep 27, 2019
Member
I think we can omit this. Hardcoding the limit here is not very useful and AFAICT the ngtcp2 backend doesn't set a limit, so we should probably be consistent.
I think we can omit this. Hardcoding the limit here is not very useful and AFAICT the ngtcp2 backend doesn't set a limit, so we should probably be consistent.
LPardue
Sep 27, 2019
Author
Contributor
Make sense. For anyone not tracking H3 specs closely, if an endpoint doesn't set a HTTP_MAX_HEADER_LIST_SIZE it is treated as effectively unlimited. Constructing the Config object and not setting anything will invoke that behaviour.
Make sense. For anyone not tracking H3 specs closely, if an endpoint doesn't set a HTTP_MAX_HEADER_LIST_SIZE it is treated as effectively unlimited. Constructing the Config object and not setting anything will invoke that behaviour.
Co-Authored-By: Alessandro Ghedini <alessandro@ghedini.me>
|
The quiche PR was merged, so to avoid breaking other curl builds I squashed and pushed this change manually as 19338e9 even if the builds are not finished yet (I tested this locally first). If something breaks I'll look into preparing a fix. |
|
Aaaaand I forgot to add "Closes: ..." to the commit message |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Depends on pending changes to quiche: 4a51aad615975a4051ea32e2d25104feac90c430 and 906646c43512efcd651f415b279cb89797c97fb8. See https://github.com/cloudflare/quiche/pull/180/commits for context