New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quiche: update HTTP/3 config creation to new API #4437
Conversation
lib/vquic/quiche.c
Outdated
if(!qs->h3config) | ||
return CURLE_OUT_OF_MEMORY; | ||
|
||
quiche_h3_config_set_max_header_list_size(qs->h3config, 1024); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can omit this. Hardcoding the limit here is not very useful and AFAICT the ngtcp2 backend doesn't set a limit, so we should probably be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. For anyone not tracking H3 specs closely, if an endpoint doesn't set a HTTP_MAX_HEADER_LIST_SIZE it is treated as effectively unlimited. Constructing the Config object and not setting anything will invoke that behaviour.
57e1bed
to
0dc3e17
Compare
Co-Authored-By: Alessandro Ghedini <alessandro@ghedini.me>
The quiche PR was merged, so to avoid breaking other curl builds I squashed and pushed this change manually as 19338e9 even if the builds are not finished yet (I tested this locally first). If something breaks I'll look into preparing a fix. |
Aaaaand I forgot to add "Closes: ..." to the commit message |
Depends on pending changes to quiche: 4a51aad615975a4051ea32e2d25104feac90c430 and 906646c43512efcd651f415b279cb89797c97fb8. See https://github.com/cloudflare/quiche/pull/180/commits for context