Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upquiche: update HTTP/3 config creation to new API #4437
Conversation
| if(!qs->h3config) | ||
| return CURLE_OUT_OF_MEMORY; | ||
|
|
||
| quiche_h3_config_set_max_header_list_size(qs->h3config, 1024); |
This comment has been minimized.
This comment has been minimized.
ghedo
Sep 27, 2019
Member
I think we can omit this. Hardcoding the limit here is not very useful and AFAICT the ngtcp2 backend doesn't set a limit, so we should probably be consistent.
This comment has been minimized.
This comment has been minimized.
LPardue
Sep 27, 2019
Author
Contributor
Make sense. For anyone not tracking H3 specs closely, if an endpoint doesn't set a HTTP_MAX_HEADER_LIST_SIZE it is treated as effectively unlimited. Constructing the Config object and not setting anything will invoke that behaviour.
Co-Authored-By: Alessandro Ghedini <alessandro@ghedini.me>
This comment has been minimized.
This comment has been minimized.
|
The quiche PR was merged, so to avoid breaking other curl builds I squashed and pushed this change manually as 19338e9 even if the builds are not finished yet (I tested this locally first). If something breaks I'll look into preparing a fix. |
This comment has been minimized.
This comment has been minimized.
|
Aaaaand I forgot to add "Closes: ..." to the commit message |
LPardue commentedSep 27, 2019
Depends on pending changes to quiche: 4a51aad615975a4051ea32e2d25104feac90c430 and 906646c43512efcd651f415b279cb89797c97fb8. See https://github.com/cloudflare/quiche/pull/180/commits for context