[git]: Add tests/server/disabled to .gitignore#4441
Closed
cvengler wants to merge 1 commit intocurl:masterfrom
cvengler:2019-09-add-disabled-to-gitignore
Closed
[git]: Add tests/server/disabled to .gitignore#4441cvengler wants to merge 1 commit intocurl:masterfrom cvengler:2019-09-add-disabled-to-gitignore
cvengler wants to merge 1 commit intocurl:masterfrom
cvengler:2019-09-add-disabled-to-gitignore
Conversation
bagder
reviewed
Sep 29, 2019
Member
bagder
left a comment
There was a problem hiding this comment.
There's a tests/server/.gitignore already. Isn't that a better places for this ignore?
Contributor
Author
|
@bagder Of course! Didn't knew that .gitignore files need to be in the project root |
Contributor
Author
|
Done |
bagder
approved these changes
Sep 30, 2019
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I did
make test, I realized that a new file calledtests/server/disabledis being generated and listed in the upstaged git changes.Using cat on this file shows that it is a binary: