Skip to content

Fix warnings from autobuilds#4444

Closed
MarcelRaad wants to merge 3 commits intocurl:masterfrom
MarcelRaad:autobuild_warnings
Closed

Fix warnings from autobuilds#4444
MarcelRaad wants to merge 3 commits intocurl:masterfrom
MarcelRaad:autobuild_warnings

Conversation

@MarcelRaad
Copy link
Member

  • implicit narrowing conversions
  • unused local variable dest
  • use of uninitialized value $file in pattern match

`dest` is only used with `ENABLE_IPV6`.

Closes
The loop doesn't need to be executed without a file argument.

Closes
@MarcelRaad
Copy link
Member Author

@bagder Any idea why the perl warnings e.g. from the Solaris testers appear on the single log page, but don't count as warnings on the overview page? Is that by design?

@bagder
Copy link
Member

bagder commented Sep 30, 2019

It's not by design. It sounds like a bug in the script collecting the bugs for the overview. Somehow...

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 1, 2019
`dest` is only used with `ENABLE_IPV6`.

Closes curl#4444
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 1, 2019
The loop doesn't need to be executed without a file argument.

Closes curl#4444
@MarcelRaad MarcelRaad closed this in 69d95b6 Oct 1, 2019
@MarcelRaad MarcelRaad deleted the autobuild_warnings branch October 1, 2019 08:52
@lock lock bot locked as resolved and limited conversation to collaborators Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants