Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from autobuilds #4444

Closed
wants to merge 3 commits into from
Closed

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Sep 30, 2019

  • implicit narrowing conversions
  • unused local variable dest
  • use of uninitialized value $file in pattern match
MarcelRaad added 3 commits Sep 30, 2019
Closes
`dest` is only used with `ENABLE_IPV6`.

Closes
The loop doesn't need to be executed without a file argument.

Closes
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Sep 30, 2019

@bagder Any idea why the perl warnings e.g. from the Solaris testers appear on the single log page, but don't count as warnings on the overview page? Is that by design?

@bagder
Copy link
Member

@bagder bagder commented Sep 30, 2019

It's not by design. It sounds like a bug in the script collecting the bugs for the overview. Somehow...

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 1, 2019
`dest` is only used with `ENABLE_IPV6`.

Closes curl#4444
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 1, 2019
The loop doesn't need to be executed without a file argument.

Closes curl#4444
@MarcelRaad MarcelRaad closed this in 69d95b6 Oct 1, 2019
@MarcelRaad MarcelRaad deleted the MarcelRaad:autobuild_warnings branch Oct 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.