Skip to content

Added a note on failed handles not being counted by curl_multi_perform.#4446

Closed
akashihi wants to merge 1 commit intocurl:masterfrom
akashihi:multiwaitdoc
Closed

Added a note on failed handles not being counted by curl_multi_perform.#4446
akashihi wants to merge 1 commit intocurl:masterfrom
akashihi:multiwaitdoc

Conversation

@akashihi
Copy link

@akashihi akashihi commented Oct 1, 2019

No description provided.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help in improving the docs!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "a transfer" or "transfers" (not "transfer")
  2. Why is this likely to happen "especially" in the case you reuse handles? In my view, transfers are always roughly equally likely to fail.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fixed
  2. Well, you are right, fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The number of "running handles" is increased by curl_multi_add_handle so a slow start doesn't result in a lower number. The number is however decreased when the transfer is complete, which can happen at any point and thus already in the fist call to curl_multi_perform().

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased to be more precise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about instead trying to not duplicate what the curl_multi_perform.3 man page already says ? We can instead rather remove the (possibly slightly misleading) sentence "Tracking when this number changes, you know when one or more transfers are done."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@bagder bagder closed this in 0b38639 Oct 3, 2019
@bagder
Copy link
Member

bagder commented Oct 3, 2019

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants