Added a note on failed handles not being counted by curl_multi_perform.#4446
Added a note on failed handles not being counted by curl_multi_perform.#4446akashihi wants to merge 1 commit intocurl:masterfrom
Conversation
bagder
left a comment
There was a problem hiding this comment.
Thanks for your help in improving the docs!
docs/libcurl/libcurl-multi.3
Outdated
There was a problem hiding this comment.
- "a transfer" or "transfers" (not "transfer")
- Why is this likely to happen "especially" in the case you reuse handles? In my view, transfers are always roughly equally likely to fail.
There was a problem hiding this comment.
- Fixed
- Well, you are right, fixed.
docs/libcurl/libcurl-multi.3
Outdated
There was a problem hiding this comment.
This is incorrect. The number of "running handles" is increased by curl_multi_add_handle so a slow start doesn't result in a lower number. The number is however decreased when the transfer is complete, which can happen at any point and thus already in the fist call to curl_multi_perform().
There was a problem hiding this comment.
How about instead trying to not duplicate what the curl_multi_perform.3 man page already says ? We can instead rather remove the (possibly slightly misleading) sentence "Tracking when this number changes, you know when one or more transfers are done."
|
Thanks! |
No description provided.