Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HTTP 429 triggers --retry #4465

Closed
wants to merge 1 commit into from

Conversation

@stain
Copy link
Contributor

commented Oct 4, 2019

This completes #3794 by making the --retry logic be triggered also on HTTP/1.1 429 Too Many Requests from RFC6586 e.g. as used by Zenodo API and as initially mentioned in #3794 by john-hascall.

Also make sure the new tests from #4195 are enabled (although the existing tests seemed to worked fine even modified for 429 status code, as the handling logic is in src/tool_operate.c was not involved by test?)

Note that the caller still needs to use --retry n to enable handling of the Retry-After header.

This completes #3794

Also make sure the new tests from #4195 are enabled
@bagder
bagder approved these changes Oct 4, 2019
Copy link
Member

left a comment

Nice and clean!

@bagder

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Don't be alarmed by the red CI build(s), that's just due to flaky/bad environments and not because of any flaw in your PR. Ignore them.

@bagder bagder closed this in f7f0b00 Oct 5, 2019
@bagder

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Thanks!

@stain stain deleted the stain:http-429 branch Oct 7, 2019
stain added a commit to stain/ro-index-paper that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.