Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix conversion warnings #4483

Closed
wants to merge 2 commits into from
Closed

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Oct 13, 2019

These occur with MinGW-w64 using WinSock.

MarcelRaad added 2 commits Oct 13, 2019
With MinGW-w64 using WinSock, `curl_socklen_t` is signed, while the
result of `sizeof` is unsigned.

Closes
With MinGW-w64, `curl_socket_t` is is a 32 or 64 bit unsigned integer,
while `read` expects a 32 bit signed integer.
Use `sread` instead of `read` to use the correct parameter type.

Closes
@jay jay added build Windows labels Oct 13, 2019
@jay
jay approved these changes Oct 13, 2019
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 13, 2019
With MinGW-w64, `curl_socket_t` is is a 32 or 64 bit unsigned integer,
while `read` expects a 32 bit signed integer.
Use `sread` instead of `read` to use the correct parameter type.

Closes curl#4483
@MarcelRaad MarcelRaad deleted the MarcelRaad:mingw_signcompare branch Oct 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.