Merged
Conversation
MarcelRaad
force-pushed
the
tests_disable_proxy
branch
from
09ef4e7 to
23ea7d8
Compare
This makes the tests succeed when using --disable-proxy. Closes curl#4488
MarcelRaad
force-pushed
the
tests_disable_proxy
branch
from
23ea7d8 to
476eb88
Compare
bagder
approved these changes
Oct 15, 2019
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Lovely, after this lands we can also consider adding a --disable-proxy build to the CI set!
Member
Author
|
Yes, that's exactly what I'm currently trying to do in my fork :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the tests succeed when using
--disable-proxy.