Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use proxy feature #4488

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Oct 15, 2019

This makes the tests succeed when using --disable-proxy.

@MarcelRaad MarcelRaad added the tests label Oct 15, 2019
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 15, 2019
This makes the tests succeed when using --disable-proxy.

Closes curl#4488
@MarcelRaad MarcelRaad force-pushed the MarcelRaad:tests_disable_proxy branch from 09ef4e7 to 23ea7d8 Oct 15, 2019
This makes the tests succeed when using --disable-proxy.

Closes #4488
@MarcelRaad MarcelRaad force-pushed the MarcelRaad:tests_disable_proxy branch from 23ea7d8 to 476eb88 Oct 15, 2019
@bagder
bagder approved these changes Oct 15, 2019
Copy link
Member

bagder left a comment

Lovely, after this lands we can also consider adding a --disable-proxy build to the CI set!

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Oct 15, 2019

Yes, that's exactly what I'm currently trying to do in my fork :-)

@MarcelRaad MarcelRaad merged commit 476eb88 into curl:master Oct 15, 2019
11 of 14 checks passed
11 of 14 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
FreeBSD FreeBSD:freebsd-10-4 Task Summary
Details
FreeBSD FreeBSD:freebsd-11-3-snap Task Summary
Details
FreeBSD FreeBSD:freebsd-12-0 Task Summary
Details
FreeBSD FreeBSD:freebsd-13-0-snap Task Summary
Details
buildbot/curl_winssl_cross_x64 Build done.
Details
buildbot/curl_winssl_cross_x64_dbg Build done.
Details
buildbot/curl_winssl_cross_x86 Build done.
Details
buildbot/curl_winssl_cross_x86_dbg Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.0%) to 74.613%
Details
@MarcelRaad MarcelRaad deleted the MarcelRaad:tests_disable_proxy branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.