-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: add --parallel-immediate #4500
Conversation
I'd call it something easier to understand for anyone reading a shell script like |
Yeah. Naming is hard. I'll think some more on this.
I'm sorry, I don't understand this comment. This is the PR that introduces pipewait for the curl tool when doing parallel transfers... |
Oh I thought that already went in, I must have misread. I thought this: On second thought I think an option to disable it could be useful for when there is prior knowledge of a server. |
That's my thinking as well! |
Alternative name suggestions for this option:
I think my personal preference is the last one here. |
I don't like any of those but I still like --parallel-nowait, somewhat. |
Out of the suggestions replied on the mailing list and as responses to my tweet, the only real contender that could work that I spotted is |
d056dbb
to
9df751b
Compare
I think I'm done bike-shedding this now. It is a rather minor option anyway and few people will want to use it. I rebased and force-pushed, will work on merging this soon. |
Starting with this change when doing parallel transfers, without this option set, curl will prefer to create new transfers multiplexed on an existing connection rather than creating a brand new one. --parallel-immediate can be set to tell curl to prefer to use new connections rather than to wait and try to multiplex. libcurl-wise, this means that curl will set CURLOPT_PIPEWAIT by default on parallel transfers. Suggested-by: Tom van der Woerdt
9df751b
to
c9baf5d
Compare
Starting with this change when doing parallel transfers, without this
option set, curl will prefer to create new transfers multiplexed on an
existing connection rather than creating a brand new one.
--parallel-connect can be set to tell curl to prefer to use new
connections rather than to wait and try to multiplex.
libcurl-wise, this means that curl will set CURLOPT_PIPEWAIT by default
on parallel transfers.
Fixes #4494
Suggested-by: Tom van der Woerdt