examples/sslbackend: fix -Wchar-subscripts warning#4503
Closed
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Closed
examples/sslbackend: fix -Wchar-subscripts warning#4503MarcelRaad wants to merge 1 commit intocurl:masterfrom
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Conversation
With the `isdigit` implementation that comes with MSYS2, the argument is used as an array subscript, resulting in a -Wchar-subscripts warning. `isdigit`'s behavior is undefined if the argument is negative and not EOF [0]. As done in lib/curl_ctype.h, cast the `char` variable to `unsigned char` to avoid that. [0] https://en.cppreference.com/w/c/string/byte/isdigit Closes
bagder
approved these changes
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
isdigitimplementation that comes with MSYS2, the argumentis used as an array subscript, resulting in a -Wchar-subscripts
warning.
isdigit's behavior is undefined if the argument is negativeand not EOF [0]. As done in lib/curl_ctype.h, cast the
charvariableto
unsigned charto avoid that.[0] https://en.cppreference.com/w/c/string/byte/isdigit