Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: make one of the winbuilds use DEBUG=no #4523

Closed
wants to merge 6 commits into from

Conversation

@bagder
Copy link
Member

bagder commented Oct 24, 2019

... and invoke "curl -V" once done

... and invoke "curl -V" once done
Copy link
Member

MarcelRaad left a comment

Unrelated, but the other one uses VC=15 but the Visual Studio 14 path, is that on purpose?

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Oct 24, 2019

No, it's not on purpose (and it seems VC is not used for much within those makefiles). I always get totally confused by those VC versions...

@jay

This comment has been minimized.

Copy link
Member

jay commented Oct 24, 2019

Why is this needed, DEBUG is off by default isn't it but why wouldn't you want it on? In any case I think it would be better to add DEBUG: to each winbuild image in the matrix with yes/no (I'm pretty sure it has to be lowercase not like cmake ON/OFF) so DEBUG=%DEBUG%. I pushed something like that to your branch, it turns on debug for VS2015 and off for VS2017.

No, it's not on purpose (and it seems VC is not used for much within those makefiles). I always get totally confused by those VC versions...

The one Marcel is referring to is VS2015 which would be VC14. For VS2017 some people like VC15 but it doesn't make sense to me since there is no VC15. That's debatable though, see #2189 and https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering

Also:
OPENSSL/WINSSL removed from winbuild image configs because they're only
used by cmake.

VC version numbers:
https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering
@jay jay force-pushed the bagder/winbuild-release branch from 93085b4 to bbddd45 Oct 24, 2019
@jay jay added the Windows label Oct 24, 2019
@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Oct 24, 2019

Why is this needed, DEBUG is off by default isn't it but why wouldn't you want it on?

I figured it would be more useful to have one build of each, to test more. #4522 triggered the idea for me.

@jay

This comment has been minimized.

Copy link
Member

jay commented Oct 24, 2019

Why is this needed, DEBUG is off by default isn't it but why wouldn't you want it on?

I figured it would be more useful to have one build of each, to test more. #4522 triggered the idea for me.

Ok. Rather than vs2015 debug on and vs2017 debug off how about vs2017 for both?

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Oct 25, 2019

Rather than vs2015 debug on and vs2017 debug off how about vs2017 for both?

I also think there's value in verifying the winbuild setup for more than one VS version. Possibly we should add new builds and do two 2015 builds debug on/off and two 2017 builds debug on/off... They don't run any tests so they're fairly low impact.

bagder added 2 commits Oct 25, 2019
@bagder bagder closed this in a030d48 Oct 25, 2019
@bagder bagder deleted the bagder/winbuild-release branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.