appveyor: make one of the winbuilds use DEBUG=no #4523
Conversation
... and invoke "curl -V" once done
|
No, it's not on purpose (and it seems VC is not used for much within those makefiles). I always get totally confused by those VC versions... |
|
Why is this needed, DEBUG is off by default isn't it but why wouldn't you want it on? In any case I think it would be better to add DEBUG: to each winbuild image in the matrix with yes/no (I'm pretty sure it has to be lowercase not like cmake ON/OFF) so
The one Marcel is referring to is VS2015 which would be VC14. For VS2017 some people like VC15 but it doesn't make sense to me since there is no VC15. That's debatable though, see #2189 and https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering |
Also: OPENSSL/WINSSL removed from winbuild image configs because they're only used by cmake. VC version numbers: https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering
jay
force-pushed
the
bagder/winbuild-release
branch
from
93085b4
to
bbddd45
Compare
I figured it would be more useful to have one build of each, to test more. #4522 triggered the idea for me. |
Ok. Rather than vs2015 debug on and vs2017 debug off how about vs2017 for both? |
I also think there's value in verifying the winbuild setup for more than one VS version. Possibly we should add new builds and do two 2015 builds debug on/off and two 2017 builds debug on/off... They don't run any tests so they're fairly low impact. |
... and invoke "curl -V" once done