Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptest1558: use double slash after file: #4554
Conversation
This comment has been minimized.
This comment has been minimized.
|
OK, this obviously broke other environments and needs another try... |
This comment has been minimized.
This comment has been minimized.
|
Oops, one slash is missing on Linux... |
Classic MinGW / MSYS 1 doesn't support `MSYS2_ARG_CONV_EXCL`, so this test unnecessarily failed when using `file:/` instead of `file:///`. Closes #4554
MarcelRaad
force-pushed the
MarcelRaad:test1558_doubleslash
branch
from
d3f5301
to
d426a4e
This comment has been minimized.
This comment has been minimized.
|
The AppVeyor failure seems unrelated:
|
This comment has been minimized.
This comment has been minimized.
Yes. Both appveyor and travis seem to have random slowdowns which may cause tests to fail however all (or most, I didn't check all) the tests in that case are TFTP failures so I think something went wrong with the TFTP test server in that instance, since the other builds passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MarcelRaad commentedNov 3, 2019
•
edited
Classic MinGW / MSYS 1 doesn't support
MSYS2_ARG_CONV_EXCL, so thistest unnecessarily failed when using
file:/instead offile:///.