test1558: use double slash after file: #4554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, this obviously broke other environments and needs another try... |
|
Oops, one slash is missing on Linux... |
Classic MinGW / MSYS 1 doesn't support `MSYS2_ARG_CONV_EXCL`, so this test unnecessarily failed when using `file:/` instead of `file:///`. Closes curl#4554
MarcelRaad
force-pushed
the
test1558_doubleslash
branch
from
d3f5301
to
d426a4e
Compare
|
The AppVeyor failure seems unrelated:
|
Yes. Both appveyor and travis seem to have random slowdowns which may cause tests to fail however all (or most, I didn't check all) the tests in that case are TFTP failures so I think something went wrong with the TFTP test server in that instance, since the other builds passed. |
bagder
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Classic MinGW / MSYS 1 doesn't support
MSYS2_ARG_CONV_EXCL, so thistest unnecessarily failed when using
file:/instead offile:///.