Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test1558: use double slash after file: #4554

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Nov 3, 2019

Classic MinGW / MSYS 1 doesn't support MSYS2_ARG_CONV_EXCL, so this
test unnecessarily failed when using file:/ instead of file:///.

@MarcelRaad MarcelRaad requested a review from bagder Nov 3, 2019
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Nov 4, 2019

OK, this obviously broke other environments and needs another try...

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Nov 4, 2019

Oops, one slash is missing on Linux...

Classic MinGW / MSYS 1 doesn't support `MSYS2_ARG_CONV_EXCL`, so this
test unnecessarily failed when using `file:/` instead of `file:///`.

Closes #4554
@MarcelRaad MarcelRaad force-pushed the MarcelRaad:test1558_doubleslash branch from d3f5301 to d426a4e Nov 4, 2019
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Nov 4, 2019

The AppVeyor failure seems unrelated:

TESTFAIL: These test cases failed: 1007 1009 1049 1093 1094 1099 1238 1242 1243 2002 2003

@jay

This comment has been minimized.

Copy link
Member

jay commented Nov 7, 2019

The AppVeyor failure seems unrelated:

Yes. Both appveyor and travis seem to have random slowdowns which may cause tests to fail however all (or most, I didn't check all) the tests in that case are TFTP failures so I think something went wrong with the TFTP test server in that instance, since the other builds passed.

@bagder
bagder approved these changes Nov 8, 2019
@MarcelRaad MarcelRaad deleted the MarcelRaad:test1558_doubleslash branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.