openssl: improve error message for SYSCALL during connect #4593
Conversation
Reported-by: Paulo Roberto Tomasi Bug: https://curl.haxx.se/mail/archive-2019-11/0005.html
| @@ -2990,8 +2990,13 @@ static CURLcode ossl_connect_step2(struct connectdata *conn, int sockindex) | |||
| const char * const hostname = SSL_IS_PROXY() ? | |||
| conn->http_proxy.host.name : conn->host.name; | |||
| const long int port = SSL_IS_PROXY() ? conn->port : conn->remote_port; | |||
| char extramsg[80]=""; | |||
| int sockerr = SOCKERRNO; | |||
| if(sockerr && detail == SSL_ERROR_SYSCALL) | |||
There was a problem hiding this comment.
I modified this slightly to use strerror only if sockerr!=0 because as described in #4624 sockerr may be 0 and we don't want confusing "No error" / "Success" error messages.
There was a problem hiding this comment.
I don't know what Unchanged files with check annotations github errors are
reference is not a tree: ad73bf565bd0966e538cfca1a7244f80e64ab216
but it is? should I write github or does anyone know why that
edit: looks like a race condition, will write github
There was a problem hiding this comment.
Where do you see that error?
There was a problem hiding this comment.
It was at the bottom of this page, 3 errors, but then I restarted the job and they disappeared. There's probably a race condition, it cloned the repo and the commit I just added to this branch was not in it so I'm guessing the repo is cached somewhere internally and wasn't updated before the CI started. I wrote github. It's still in beta so I would just restart if you see bad tree errors.
jay
force-pushed
the
bagder/openssl-connect-errormsg
branch
from
ad73bf5 to
13610da
Compare
Reported-by: Paulo Roberto Tomasi
Bug: https://curl.haxx.se/mail/archive-2019-11/0005.html