openssl: improve error message for SYSCALL during connect #4593
Conversation
Reported-by: Paulo Roberto Tomasi Bug: https://curl.haxx.se/mail/archive-2019-11/0005.html
| @@ -2990,8 +2990,13 @@ static CURLcode ossl_connect_step2(struct connectdata *conn, int sockindex) | |||
| const char * const hostname = SSL_IS_PROXY() ? | |||
| conn->http_proxy.host.name : conn->host.name; | |||
| const long int port = SSL_IS_PROXY() ? conn->port : conn->remote_port; | |||
| char extramsg[80]=""; | |||
| int sockerr = SOCKERRNO; | |||
| if(sockerr && detail == SSL_ERROR_SYSCALL) | |||
jay
Nov 22, 2019
Member
I modified this slightly to use strerror only if sockerr!=0 because as described in #4624 sockerr may be 0 and we don't want confusing "No error" / "Success" error messages.
I modified this slightly to use strerror only if sockerr!=0 because as described in #4624 sockerr may be 0 and we don't want confusing "No error" / "Success" error messages.
bagder
Nov 22, 2019
Author
Member
Where do you see that error?
Where do you see that error?
jay
Nov 22, 2019
Member
It was at the bottom of this page, 3 errors, but then I restarted the job and they disappeared. There's probably a race condition, it cloned the repo and the commit I just added to this branch was not in it so I'm guessing the repo is cached somewhere internally and wasn't updated before the CI started. I wrote github. It's still in beta so I would just restart if you see bad tree errors.
It was at the bottom of this page, 3 errors, but then I restarted the job and they disappeared. There's probably a race condition, it cloned the repo and the commit I just added to this branch was not in it so I'm guessing the repo is cached somewhere internally and wasn't updated before the CI started. I wrote github. It's still in beta so I would just restart if you see bad tree errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reported-by: Paulo Roberto Tomasi
Bug: https://curl.haxx.se/mail/archive-2019-11/0005.html