/ curl Public
ngtcp2: fix thread-safety bug in error-handling #4645
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
(I was idly looking around for
ERR_error_stringcalls and noticed this. I don't have an ngtcp2 build environment set up so this hasn't even been compile-tested, but hopefully the CI will notice if I made a typo somewhere.)
ERR_error_string(NULL)should never be called. It places the error in a global buffer, which is not thread-safe. Use
ERR_error_string_nwith a local buffer instead.