Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2: fix thread-safety bug in error-handling #4645

Closed
wants to merge 1 commit into from

Conversation

@davidben
Copy link
Contributor

@davidben davidben commented Nov 27, 2019

(I was idly looking around for ERR_error_string calls and noticed this. I don't have an ngtcp2 build environment set up so this hasn't even been compile-tested, but hopefully the CI will notice if I made a typo somewhere.)

ERR_error_string(NULL) should never be called. It places the error in a global buffer, which is not thread-safe. Use ERR_error_string_n with a local buffer instead.

ERR_error_string(NULL) should never be called. It places the error in a
global buffer, which is not thread-safe. Use ERR_error_string_n with a
local buffer instead.
@bagder
bagder approved these changes Nov 27, 2019
Copy link
Member

@bagder bagder left a comment

Awesome, thanks!

@bagder
Copy link
Member

@bagder bagder commented Nov 27, 2019

Thanks!

@bagder bagder closed this in d94aa39 Nov 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.