Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CARES_STATICLIB for Windows builds when WITH_CARES=static. #4688

Closed

Conversation

@unlightable
Copy link

unlightable commented Dec 9, 2019

When libcurl is built with MODE=static, c-ares is forced into static linkage too.
That doesn't happen when MODE=dll so linker breaks over undefined symbols.

When libcurl is built with MODE=static, c-ares is forced into static linkage too.
That doesn't happen when MODE=dll so linker breaks over undefined symbols.
@bagder
bagder approved these changes Dec 9, 2019
Copy link
Member

bagder left a comment

Seems totally reasonable!

@jay jay added build Windows labels Dec 10, 2019
@jay jay closed this in 476a832 Dec 10, 2019
@jay
Copy link
Member

jay commented Dec 10, 2019

Thanks

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.