--libcurl: problem with output of non-printable characters was fixed#469
Closed
majstar wants to merge 1 commit intocurl:masterfrom
Closed
--libcurl: problem with output of non-printable characters was fixed#469majstar wants to merge 1 commit intocurl:masterfrom
majstar wants to merge 1 commit intocurl:masterfrom
Conversation
Member
|
Thanks, that was a bug. Your fix landed in 2eb4f5e. If your binary data has null bytes truncation will still occur in the source generation when |
jgsogo
pushed a commit
to jgsogo/curl
that referenced
this pull request
Oct 19, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I have found a little problem with output of non-printable characters when --libcurl option is used.
For example, we are trying to post contents of binfile.bin file with non-printable characters inside:
~> cat binfile.bin
���
~> curl --libcurl ~/result.c --request POST --data-binary "@binfile.bin" http://tut.by
some cURL output
~> cat result.c
// skip a few lines
curl_easy_setopt(hnd, CURLOPT_POSTFIELDS, "\02");
As you can see, the content of binfile.bin file was not copied correctly to the generated C source file.
The problem occurs because snprintf function reserves space for the additional terminating null character. The fix is provided in 9414a9e commit.