Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CURL_STATICLIB warning to static linking instructions. #4721

Closed
wants to merge 1 commit into from

Conversation

@mvittiglio
Copy link

@mvittiglio mvittiglio commented Dec 15, 2019

This should help with future users to prevent some head-scratching and keyboard-smashing.

This should help with future users to prevent some head-scratching and keyboard-smashing.
@jay
Copy link
Member

@jay jay commented Dec 15, 2019

This is already covered in INSTALL.md and in the FAQ. Why do we need it in the build notes?

@jay jay added the documentation label Dec 15, 2019
@mvittiglio
Copy link
Author

@mvittiglio mvittiglio commented Dec 15, 2019

@jay I appreciate that having information increases the upkeep of said knowledge. My thought is that putting this critical bit adjacent to the windows readme info (where some information is already being duplicated regardless) can only help prevent unnecessary time wasted. Perhaps, ideally, a wiki could get around this by linking between info but, easier would be to include this critical "gotcha" in the document for the time being.

That's just my 2 cents so feel free to disregard. Have a great day!

@jay jay closed this in b0a9e3c Dec 15, 2019
@jay
Copy link
Member

@jay jay commented Dec 15, 2019

Ref: #4716

Ok. I went with a different wording that is close to that in the FAQ.

@jay
Copy link
Member

@jay jay commented Dec 15, 2019

Thanks

@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.