Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define: remove HAVE_ENGINE_LOAD_BUILTIN_ENGINES, not used anymore #4725

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

bagder commented Dec 16, 2019

Reported-by: Gisle Vanem
Bug: 87b9337#commitcomment-36447951

@bagder
Copy link
Member Author

bagder commented Dec 16, 2019

Ah, I missed the use of it... Its in lib/vtls/openssl.c. Bad PR, closing.

The function is used there, the define is not...

@bagder bagder closed this Dec 16, 2019
@bagder bagder deleted the bagder/HAVE_ENGINE_LOAD_BUILTIN_ENGINES branch Dec 16, 2019
@bagder bagder restored the bagder/HAVE_ENGINE_LOAD_BUILTIN_ENGINES branch Dec 16, 2019
Reported-by: Gisle Vanem
Bug: 87b9337#commitcomment-36447951

Closes #4725
@bagder bagder reopened this Dec 16, 2019
@bagder bagder force-pushed the bagder/HAVE_ENGINE_LOAD_BUILTIN_ENGINES branch from 48c93b3 to 82ffd60 Dec 16, 2019
@jay
Copy link
Member

jay commented Dec 16, 2019

seems it was replaced by USE_OPENSSL_ENGINE

curl/lib/vtls/openssl.c

Lines 73 to 77 in 2e9b725

#if (OPENSSL_VERSION_NUMBER >= 0x0090700fL) && /* 0.9.7 or later */ \
!defined(OPENSSL_NO_ENGINE) && !defined(OPENSSL_NO_UI_CONSOLE)
#define USE_OPENSSL_ENGINE
#include <openssl/engine.h>
#endif

@jay jay added the SSL/TLS label Dec 16, 2019
@bagder
Copy link
Member Author

bagder commented Dec 16, 2019

(unrelated) 1456 test failure on azure ubuntu (again)....

@bagder bagder closed this in 0caf142 Dec 17, 2019
@bagder bagder deleted the bagder/HAVE_ENGINE_LOAD_BUILTIN_ENGINES branch Dec 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.