Minorfix #4756
Closed
Minorfix #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I015afcec67921fae6ffa2f55a6a65bff4e5a07f5 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I96a966a252b62cd34dc2330d1a8d2abeee03a878 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I41c2a55abd3a4f738568c42f1458c4f7f10a3a5f Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
modified by commit eb9a604 accidently Change-Id: I32ab5fa7f9caba29e29dfa15d5633a92a90c6bca Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
jay
requested changes
Dec 24, 2019
lib/asyn-thread.c
Outdated
| @@ -667,7 +667,7 @@ int Curl_resolver_getsock(struct connectdata *conn, | |||
| #endif | |||
| ms = Curl_timediff(Curl_now(), reslv->start); | |||
| if(ms < 3) | |||
| milli = 0; | |||
| milli = ms; | |||
There was a problem hiding this comment.
Sorry, we have a better fix. I remove this patch from pull request, pleaase ignore it.
| @@ -374,6 +374,7 @@ typedef int sig_atomic_t; | |||
| * Macro used to include assertion code only in debug builds. | |||
| */ | |||
|
|
|||
| #undef DEBUGASSERT | |||
| #if defined(DEBUGBUILD) && defined(HAVE_ASSERT_H) | |||
| #define DEBUGASSERT(x) assert(x) | |||
There was a problem hiding this comment.
Where is DEBUGASSERT already defined?
There was a problem hiding this comment.
Many OS or library define DEBUGASSERT, you can see here:
https://github.com/search?l=C&p=1&q=DEBUGASSERT&type=Code
One I really hit is:
https://github.com/apache/incubator-nuttx/blob/master/include/assert.h
Anyway, it isn't harmful to undefine it before define.
xiaoxiang781216
force-pushed
the
minorfix
branch
from
88439c7
to
90e7e56
Compare
|
Thanks. You may want to investigate why CURL_SIZEOF_CURL_OFF_T is <= 4. In most cases CURL_SIZEOF_CURL_OFF_T should be 8 because most compilers can support 64-bit curl_off_t even if the platform is 32-bit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when porting to NuttX