Make CURLOPT_CAINFO work on Windows 7 #4761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix the issue reported here #3711 |
faizur
force-pushed
the
schannel_win7
branch
2 times, most recently
from
9be23de
to
3e7d828
Compare
|
Neat. Does this handle wildcards like *.foo.amazon.com? /cc @jeroen |
faizur
force-pushed
the
schannel_win7
branch
from
3e7d828
to
0204c38
Compare
|
@jay It does handle wildcards. Actually, the logic(Curl_cert_hostcheck) to handle those hasn't changed. |
|
AFAICT, the failing two checks seem to be flaky. |
faizur
force-pushed
the
schannel_win7
branch
from
0204c38
to
f2f89f9
Compare
Yes. I've set it to re-run the failed checks. |
Thanks! Down to one failing check now. |
CERT_NAME_SEARCH_ALL_NAMES_FLAG doesn't exist before Windows 8. As a result CertGetNameString doesn't quite work on those versions of Windows. This change provides an alternative solution for CertGetNameString by iterating through CERT_ALT_NAME_INFO for earlier versions of Windows.
|
Thanks |
jay
added a commit
that referenced
this pull request
Jan 13, 2020
Follow-up to 29e40a6 from two days ago, which added that feature for Windows 7 and earlier. The bug only occurred in same. Ref: #4761
|
I missed a bug, a char * was used to advance a tchar * which caused problems in Unicode builds. Fixed in 16da8bc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CERT_NAME_SEARCH_ALL_NAMES_FLAG doesn't exist before Windows 8. As a
result CertGetNameString doesn't quite work on those versions of
Windows. This change provides an alternative solution for
CertGetNameString by iterating through CERT_ALT_NAME_INFO for earlier
versions of Windows.