Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Let -D merge headers in one file again #4762

Closed
wants to merge 2 commits into from

Conversation

@emilengler
Copy link
Contributor

emilengler commented Dec 27, 2019

Fix for #4753
We check if this is the first run of the function, if so create a new file. The function is getting executed node by node of the linked list so we just check if it the first node by checking if the previous element is NULL.

@jay
Copy link
Member

jay commented Dec 27, 2019

Why do the tests need to be adjusted? Also, IIRC the way header file used to work was it was opened once, does something close it now?

@jay jay added the cmdline tool label Dec 27, 2019
@emilengler
Copy link
Contributor Author

emilengler commented Dec 27, 2019

Why do the tests need to be adjusted?

They were changed with b889408

@emilengler
Copy link
Contributor Author

emilengler commented Dec 27, 2019

Also, IIRC the way header file used to work was it was opened once, does something close it now?

Maybe src/tool_cb_hdr.c:194? (Not 100% sure, did a quick look)

@bagder
Copy link
Member

bagder commented Jan 17, 2020

  1. The metalink tests fail. Both the freebsd ones and the travis ones on Linux.
  2. "This branch cannot be rebased safely"
@emilengler
Copy link
Contributor Author

emilengler commented Jan 17, 2020

@bagder Will rebase it now and try to fix the tests

@emilengler
Copy link
Contributor Author

emilengler commented Jan 17, 2020

The patch itself just got rebased. I will adjust the tests now

@emilengler
Copy link
Contributor Author

emilengler commented Jan 17, 2020

I adjusted the tests with a695a36. They should pass now

@bagder
Copy link
Member

bagder commented Jan 21, 2020

Thanks!

@bagder bagder closed this in 1774dbd Jan 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.