Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: Refactor Curl_multissl_version to make the code clearer #4803

Closed
wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

jay commented Jan 10, 2020

Reported-by: Johannes Schindelin

Ref: #3863 (review)


/cc @dscho

@bagder
bagder approved these changes Jan 10, 2020
Copy link
Contributor

dscho left a comment

I am slightly concerned by the segmentation fault in Travis but could not quickly verify whether this patch is the cause.

lib/vtls/vtls.c Outdated Show resolved Hide resolved
lib/vtls/vtls.c Outdated Show resolved Hide resolved
@bagder
Copy link
Member

bagder commented Jan 10, 2020

Unfortunately, the arm64 builds on travis are totally unreliable and do these seemingly random segfaults every now and then. I've never managed to reproduce them when manually running the tests on arm64 machines.

Reported-by: Johannes Schindelin

Ref: #3863 (review)
@jay jay force-pushed the jay:refactor_Curl_multissl_version branch from 2e8a636 to ba48050 Jan 10, 2020
@dscho
dscho approved these changes Jan 10, 2020
@dscho
Copy link
Contributor

dscho commented Jan 10, 2020

Unfortunately, the arm64 builds on travis are totally unreliable and do these seemingly random segfaults every now and then. I've never managed to reproduce them when manually running the tests on arm64 machines.

@bagder thank you for clarifying!

@jay jay closed this in c9c551f Jan 12, 2020
@jay
Copy link
Member Author

jay commented Jan 12, 2020

Thanks

@jay jay deleted the jay:refactor_Curl_multissl_version branch Jan 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.