Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default EXPECT_100_THRESHOLD 1Mb #4814

Closed
wants to merge 3 commits into from
Closed

Conversation

@FumiyukiKato
Copy link
Contributor

@FumiyukiKato FumiyukiKato commented Jan 14, 2020

detailed reference: #3524

When using a wrapper library of libcurl, I had a problem in HTTP protocol because Header "Expect: 100-continue" is added implicitly.
'Expect' Header is written clearly in RFC 7231 but not so commonly used now.
As we can see #3524 discussion, this constraint can be relaxed, and it seems that has already been concluded so.

@FumiyukiKato FumiyukiKato requested a review from bagder Jan 14, 2020
@jay jay added the HTTP label Jan 14, 2020
@bagder
bagder approved these changes Jan 14, 2020
Copy link
Member

@bagder bagder left a comment

I found a mention of the 1024 bytes limit in the CURLOPT_POSTFIELDS.3 man page that needs an update. Other than that, I'm a 👍

@bagder
Copy link
Member

@bagder bagder commented Jan 15, 2020

I mentioned this change on the mailing list, just to give people a chance to respond or have opinions before merge. Let's just keep this open a few days for that purpose.

@FumiyukiKato
Copy link
Contributor Author

@FumiyukiKato FumiyukiKato commented Jan 15, 2020

OK. Thanks!

@bagder
Copy link
Member

@bagder bagder commented Jan 20, 2020

Thanks!

@bagder bagder closed this in 7ff9222 Jan 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.