Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS400 check dupstring enumeration at build time, not runtime #4822

Closed
wants to merge 7 commits into from

Conversation

@jonrumsey
Copy link
Contributor

@jonrumsey jonrumsey commented Jan 15, 2020

"*** WARNING: curl_easy_setopt_ccsid() should be reworked ***" appears at runtime on OS400 when using curl_easy_setopt_ccsid() because runtime checks in ccsidcurl.c did not account for conditional directives.

As discussed in pull request #4789, a better way to handle this would be to remove the conditional directives so that the enumeration indices don't change with compiler options, also remove the runtime check and replace with a build time check.

jonrumsey added 4 commits Jan 15, 2020
Check that updates to the dupstring enums are reflected in packages/OS400/ccsidcurl.c
Remove conditional directives and add comment to indicate what additional steps are required for OS400.
This reverts commit ec61755.
@bagder
Copy link
Member

@bagder bagder commented Jan 15, 2020

./urldata.h:1437:72: warning: Trailing whitespace (TRAILINGSPACE)
  * null terminated strings MUST be added to the enumeration immediately 
                                                                        ^
./urldata.h:1438:70: warning: Trailing whitespace (TRAILINGSPACE)
  * before STRING_LASTZEROTERMINATED, binary fields immediately before 
                                                                      ^
checksrc: 0 errors and 2 warnings
checksrc: 0 errors and 6 warnings suppressed
Remove extraneous  trailing spaces in comments
@bagder
Copy link
Member

@bagder bagder commented Jan 22, 2020

Thanks, can you squash this into a single commit and rebase it please? To make it easier to review and see what the ultimate change looks like.

…to the dupstring enums are reflected in packages/OS400/ccsidcurl.c
@jonrumsey jonrumsey force-pushed the jonrumsey:os400-chkstrings branch from b36666f to 8343acc Jan 23, 2020
…into os400-chkstrings
@bagder bagder closed this in 4228700 Jan 27, 2020
@bagder
Copy link
Member

@bagder bagder commented Jan 27, 2020

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@jonrumsey jonrumsey deleted the jonrumsey:os400-chkstrings branch Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.