Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upglobal_init: assume the EINTR bit by default #4840
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
noloader
commented
Jan 23, 2020
•
This may cause some pain points for some distros. I think distros expect See, for example, Fedora Issue 919127, Provide a CURL_GLOBAL_ACK_EINTR flag to curl_global_init(). |
This comment has been minimized.
This comment has been minimized.
|
This change changes the default to not retrying on EINTR, which is exactly what that Fedora issue wanted... So the question is if there's anything that would be affected or even notice if those functions return earlier when aborted by a signal? |
- Removed from global_init since it isn't thread-safe. The symbol will still remain to not break compiles, it just won't have any effect going forward. - make the internals NOT loop on EINTR (the opposite from previously). It only risks returning from the select/poll/wait functions early, and that should be risk-free. Closes #4840
bagder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bagder commentedJan 22, 2020
•
edited
Removed from global_init since it isn't thread-safe. The symbol will still remain to not break compiles, it just won't have any effect going forward.
make the internals NOT loop on EINTR (the opposite from previously). It only risks returning from the select/poll/wait functions early, and that should be risk-free.
Brought to the mailing list with no objections following.