Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global_init: move the IPv6 works status bool to multi handle #4851

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

bagder commented Jan 26, 2020

Previously it was stored in a global state which contributed to
curl_global_init's thread unsafety. This boolean is now instead figured
out in curl_multi_init() and stored in the multi handle. Less effective,
but thread safe.

@bagder bagder force-pushed the bagder/ipv6-works-multi branch from a34ac03 to 8369469 Jan 26, 2020
@jay

This comment has been minimized.

Copy link
Member

jay commented Jan 26, 2020

There will always be some items that need only be initialized once that's why we have an init function.

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jan 26, 2020

I think we can make it thread-safe, which is the ultimate goal with my curl_global_init work right now.

Previously it was stored in a global state which contributed to
curl_global_init's thread unsafety. This boolean is now instead figured
out in curl_multi_init() and stored in the multi handle. Less effective,
but thread safe.
@bagder bagder force-pushed the bagder/ipv6-works-multi branch from 8369469 to 94086ad Jan 27, 2020
@bagder bagder closed this in 0b030a5 Jan 28, 2020
@bagder bagder deleted the bagder/ipv6-works-multi branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.