Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using strlen for testing if a string is empty #4873

Closed
wants to merge 1 commit into from

Conversation

@orgads
Copy link
Contributor

orgads commented Feb 3, 2020

No description provided.

@bagder
bagder approved these changes Feb 3, 2020
Copy link
Member

danielgustafsson left a comment

There doesn't seem to be any other instances of this pattern AFAICT from a quick scan through the tree.

@orgads

This comment has been minimized.

Copy link
Contributor Author

orgads commented Feb 3, 2020

Wait, I found a few others :)

@orgads orgads force-pushed the orgads:no-strlen-for-empty branch from 4d84f3b to 9ebddb9 Feb 3, 2020
@orgads

This comment has been minimized.

Copy link
Contributor Author

orgads commented Feb 3, 2020

Wait, there's more.

@orgads orgads force-pushed the orgads:no-strlen-for-empty branch from 9ebddb9 to c9703d0 Feb 3, 2020
@orgads

This comment has been minimized.

Copy link
Contributor Author

orgads commented Feb 3, 2020

Ok, I'm done.

tests/unit/unit1652.c Outdated Show resolved Hide resolved
docs/examples/synctime.c Outdated Show resolved Hide resolved
@orgads orgads force-pushed the orgads:no-strlen-for-empty branch from c9703d0 to ca78cae Feb 3, 2020
@bagder

This comment has been minimized.

Copy link
Member

bagder commented Feb 4, 2020

Thanks!

@bagder bagder closed this in 2bc3737 Feb 4, 2020
@orgads orgads deleted the orgads:no-strlen-for-empty branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.