Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digest: Do not quote algorithm in Authorization header #4890

Closed
wants to merge 1 commit into from

Conversation

@PyvesB
Copy link
Contributor

PyvesB commented Feb 6, 2020

RFC 7616 section 3.4 (The Authorization Header Field) states that "For historical reasons, a sender MUST NOT generate the quoted string syntax for the following parameters: algorithm, qop, and nc". This removes the quoting for the algorithm parameter.

Copy link
Member

captain-caveman2k left a comment

A couple of minor review comments from me:

  • I would word the title of this commit to be "digest: Do not quote algorithm in HTTP authorisation (as this doesn't affect the sasl protocols)
  • Update the copyright year to 2020 in digest.c
RFC 7616 section 3.4 (The Authorization Header Field) states that "For
historical reasons, a sender MUST NOT generate the quoted string syntax
for the following parameters: algorithm, qop, and nc". This removes the
quoting for the algorithm parameter.
@PyvesB PyvesB force-pushed the bbc:digest-auth-algorithm branch from ca4cbdb to 85f625d Feb 7, 2020
@PyvesB

This comment has been minimized.

Copy link
Contributor Author

PyvesB commented Feb 7, 2020

Thanks for the feedback @captain-caveman2k. I've changed the commit title and updated the copyright year.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Feb 7, 2020

Thanks!

@bagder bagder closed this in feba3f0 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.