Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: Include the failure reason when curl_win32_idn_to_ascii() fails #4899

Closed

Conversation

@captain-caveman2k
Copy link
Member

captain-caveman2k commented Feb 9, 2020

Provide the failure reason in the failf() info just as we do for the libidn2 version of code. Otherwise we have output such as the following which doesn't help debug what the failure is:

Failed to convert åäö.se to ACE.

Rather than:

Failed to convert åäö.se to ACE; No mapping for the Unicode character exists in the target multi-byte code page.
@jay
jay approved these changes Feb 9, 2020
@captain-caveman2k captain-caveman2k deleted the captain-caveman2k:winidn_strerror branch Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.