Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: Include the failure reason when curl_win32_idn_to_ascii() fails #4899

Closed
wants to merge 1 commit into from
Closed

url: Include the failure reason when curl_win32_idn_to_ascii() fails #4899

wants to merge 1 commit into from

Conversation

captain-caveman2k
Copy link
Contributor

@captain-caveman2k captain-caveman2k commented Feb 9, 2020 •
edited
Loading

Provide the failure reason in the failf() info just as we do for the libidn2 version of code. Otherwise we have output such as the following which doesn't help debug what the failure is:

Failed to convert åäö.se to ACE.

Rather than:

Failed to convert åäö.se to ACE; No mapping for the Unicode character exists in the target multi-byte code page.

@captain-caveman2k captain-caveman2k added the Windows Windows-specific label Feb 9, 2020
@captain-caveman2k captain-caveman2k deleted the winidn_strerror branch February 23, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

@jay jay jay approved these changes

Assignees
No one assigned
Labels
Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@captain-caveman2k @jay @MarcelRaad