Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socks: make the connect phase non-blocking #4907

Closed
wants to merge 1 commit into from
Closed

Conversation

@bagder
Copy link
Member

@bagder bagder commented Feb 11, 2020

Removes two entries from KNOWN_BUGS.

bagder added a commit that referenced this pull request Feb 11, 2020
Removes two entries from KNOWN_BUGS.

Closes #4907
@bagder bagder force-pushed the bagder/socks-nonblocking branch from 71d5047 to bc7d461 Feb 11, 2020
Removes two entries from KNOWN_BUGS.

Closes #4907
@bagder bagder force-pushed the bagder/socks-nonblocking branch from c54ae30 to 692cb46 Feb 14, 2020
@bagder bagder closed this in 4a4b63d Feb 16, 2020
@bagder bagder deleted the bagder/socks-nonblocking branch Feb 16, 2020
bagder added a commit that referenced this pull request Mar 6, 2020
Regression from 4a4b63d (and #4907)
Reported-by: vitaha85 on github
Fixes #5053
bagder added a commit that referenced this pull request Mar 7, 2020
Regression from 4a4b63d (and #4907)
Reported-by: vitaha85 on github
Fixes #5053
Closes #5056
bagder added a commit that referenced this pull request Mar 8, 2020
1. The socks4 state machine was broken in the host resolving phase

2. The code now insists on IPv4-only when using SOCKS4 as the protocol
only supports that.

Regression from #4907 and 4a4b63d, shipped in 7.69.0

Reported-by: amishmm on github
Bug: #5053 (comment)
bagder added a commit that referenced this pull request Mar 8, 2020
1. The socks4 state machine was broken in the host resolving phase

2. The code now insists on IPv4-only when using SOCKS4 as the protocol
only supports that.

Regression from #4907 and 4a4b63d, shipped in 7.69.0

Reported-by: amishmm on github
Bug: #5053 (comment)
Closes #5061
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.