Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmd5: Added mbedtls implementation #4980
Conversation
| (void) mbedtls_md5_update_ret(ctx, data, length); | ||
| } | ||
|
|
||
| static void MD5_Final(unsigned char digest[16], MD5_CTX *ctx) |
This comment has been minimized.
This comment has been minimized.
jay
Feb 25, 2020
Member
I get why you did this (because mbedtls does I assume) but I think the fixed size array style is misleading, if you sizeof(digest) it's going to be the size of the pointer not of the array. If we are passing *input I think it should just be passed as that.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
captain-caveman2k
Feb 25, 2020
•
Author
Member
Unfortunately it's not related to mbedtls, the other (well... GnuTLS based) functions use this style and you'll also note that the SHA256 code does this too (I'm guessing as the MD5 code was used as a template).
I'm personally not a fan if it because of it for the reason you gave ;-) As such you'll note I've used pointer notation in PR #4956 for my new SHA256 functions and corrected the existing function to match.
captain-caveman2k
force-pushed the
captain-caveman2k:mbedtls_md5
branch
2 times, most recently
from
90572db
to
48e62c7
captain-caveman2k
force-pushed the
captain-caveman2k:mbedtls_md5
branch
from
48e62c7
to
7ab6571
captain-caveman2k commentedFeb 25, 2020
No description provided.