unit1612: Fixed the compilation of the new unit test#5024
unit1612: Fixed the compilation of the new unit test#5024captain-caveman2k wants to merge 1 commit intocurl:masterfrom
Conversation
|
|
|
if we'll be very strict, I would also prefer if we dropped the initial uppercasing of the first letter and when possible rather spell out the actual fix rather than saying "fix". Perhaps:
|
|
I think as a requirement it's probably too strict. Keywords like fix/add/remove or whatever may help communicate an overall effect (which is then fully spelled out in the commit message), and the initial uppercase style can be found in the history occasionally. I have some bias. Take for example It could be done with some limitation in the subject as I think the first one communicates better. I'm not sure if everyone shares that view. |
|
I didn't mean it as a requirement. I just offered my take on what would make the commit message even better in my view. |
Follow on from 3f74e5e. Due to a typo in Makefile.inc unit1611 was used as test1612. Once corrected there were a few minor compilation issues to fix.
46a7a63 to
c1d3f77
Compare
Follow on from 3f74e5e. Due to a typo in Makefile.inc unit1611 was used as test1612. Once corrected there were a few minor compilation issues to fix.