Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause: return early for calls that don't change pause state #5026

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Mar 3, 2020

Ref: #4833

@monnerat, does this make things any better?

Ref: #4833
@monnerat
Copy link
Contributor

@monnerat monnerat commented Mar 3, 2020

Yes, it does and stops hanging test 670. This is very near what I tried myself while investigating. However I thought of a more elaborate solution (checking read and write pause state change separately) for a final commit.
Thanks.

@bagder
Copy link
Member Author

@bagder bagder commented Mar 5, 2020

@monnerat, are you saying you want to do it differently or that you'd be positive to land this PR?

@monnerat
Copy link
Contributor

@monnerat monnerat commented Mar 5, 2020

This is already an improvement, so you can commit it :-)

@bagder bagder closed this in 64258bd Mar 6, 2020
@bagder bagder deleted the bagder/pause-noop branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.