sha256: Added more TLS library based implementations #5030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captain-caveman2k
added
cryptography
next-feature-window
captain-caveman2k
force-pushed
the
vtls_sha256_part2
branch
from
89de88f
to
b6b8087
Compare
|
I just noticed that the |
bagder
removed
the
next-feature-window
|
For the record: I didn't intend to revert the windows crypto part, that was my mistake back in b572e0b. This PR still says "[WIP]", is there a reason for that? |
captain-caveman2k
changed the title
captain-caveman2k
force-pushed
the
vtls_sha256_part2
branch
from
b6b8087
to
639e37a
Compare
|
@captain-caveman2k can we land this now? |
|
and to repeat what @jay use to say: please use the term "add" in the commit message, not "added" (and if I get my way, use a lowercase initial letter) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Implemented SHA256 support through the following TLS libraries:
This continues #4956, reverts b572e0b which reverted both the Common Crypto and Windows Crypto implementations and fixes the problems from commit 4feb38d (Hopefully).