Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha256: Added more TLS library based implementations #5030

Closed

Conversation

@captain-caveman2k
Copy link
Member

captain-caveman2k commented Mar 3, 2020

Implemented SHA256 support through the following TLS libraries:

  • Apple's Common Crypto
  • Windows Crypto

This continues #4956, reverts b572e0b which reverted both the Common Crypto and Windows Crypto implementations and fixes the problems from commit 4feb38d (Hopefully).

@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:vtls_sha256_part2 branch from 89de88f to b6b8087 Mar 3, 2020
@nickzman
Copy link
Collaborator

nickzman commented Mar 4, 2020

I just noticed that the SSH256_Init() in the original (reverted) commit called the wrong function. This one calls the correct function.

@bagder
Copy link
Member

bagder commented Mar 5, 2020

For the record: I didn't intend to revert the windows crypto part, that was my mistake back in b572e0b.

This PR still says "[WIP]", is there a reason for that?

@captain-caveman2k captain-caveman2k changed the title [WIP] sha256: Added more TLS library based implementations sha256: Added more TLS library based implementations Mar 6, 2020
@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:vtls_sha256_part2 branch from b6b8087 to 639e37a Mar 6, 2020
@bagder
Copy link
Member

bagder commented Mar 7, 2020

@captain-caveman2k can we land this now?

@bagder
Copy link
Member

bagder commented Mar 7, 2020

and to repeat what @jay use to say: please use the term "add" in the commit message, not "added" (and if I get my way, use a lowercase initial letter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.